Skip to content

Assignment 1#2

Open
thomasdudgeon wants to merge 2 commits into
mainfrom
assignment-1
Open

Assignment 1#2
thomasdudgeon wants to merge 2 commits into
mainfrom
assignment-1

Conversation

@thomasdudgeon

Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Checking for anagrams

What did you learn from the changes you have made?

How to deconstruct words and compare them

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

No, this was the main approach

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Challenges were faced in getting the file up to GitHub, I thought it was loaded but it wasn't showing for a week. I have

it up now, hopefully there are no issues introduced.

How were these changes tested?

I re-ran the code on my machine to make sure it works.

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

@juliagallucci juliagallucci left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! One suggestion for improvement would be to return the boolean values (True/False) instead of strings and simplify the final check by directly returning the comparison result (ie word 1 == word 2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants